close ad
 
Important WebAssist Announcement
open ad
View Menu

Technical Support Forums

Free, outstanding support from WebAssist and your colleagues

Directory traversal attacks

Thread began 4/26/2022 1:59 am by Mags | Last modified 4/27/2022 12:10 pm by Mags | 237 views | 4 replies

Ray BorduinWebAssist

The issue is on the eldesk-tech-support.php page.

You are getting the name of the file to download from a hidden form element. That allows a would-be hacker to change the value of the hidden form element to download whatever file they want from your site.

Instead you should remove the hidden form element and get the file name from the recordset directly. So instead of this on line 17:

WA_DFP_DownloadFile("WA_DownloadResult1", "downloads/helpdesk/", "".((isset($_POST["hidden"]))?$_POST["hidden"]:"")  ."", "".((isset($_POST["hiddenname"]))?$_POST["hiddenname"]:"")  ."", false, false, false, "", "", "", "");
}



Instead use:

WA_DFP_DownloadFile("WA_DownloadResult1", "downloads/helpdesk/", "".($rsHelpdesk->getColumnVal('File',false))  ."", "".($rsHelpdesk->getColumnVal('Title'))  ."", false, false, false, "", "", "", "");
}



Then you can delete your two hidden form elements. That way the file name can't be manipulated. Paths in other locations aren't relevant and can be left as they are.


Did this help? Tips are appreciated...

Build websites with a little help from your friends

Your friends over here at WebAssist! These Dreamweaver extensions will assist you in building unlimited, custom websites.

Build websites from already-built web applications

These out-of-the-box solutions provide you proven, tested applications that can be up and running now.  Build a store, a gallery, or a web-based email solution.

Want your website pre-built and hosted?

Close Windowclose

Rate your experience or provide feedback on this page

Account or customer service questions?
Please user our contact form.

Need technical support?
Please visit support to ask a question

Content

rating

Layout

rating

Ease of use

rating

security code refresh image

We do not respond to comments submitted from this page directly, but we do read and analyze any feedback and will use it to help make your experience better in the future.

Close Windowclose

We were unable to retrieve the attached file

Close Windowclose

Attach and remove files

add attachmentAdd attachment
Close Windowclose

Enter the URL you would like to link to in your post

Close Windowclose

This is how you use right click RTF editing

Enable right click RTF editing option allows you to add html markup into your tutorial such as images, bulleted lists, files and more...

-- click to close --

Uploading file...