product detail not showing if downloads is empty

Hi Ray

Have attached a page which shows the product detail.

I have also set it up so that a list of downloads shows if a user is logged in.

The problem is that if there are no downloads associated with the product (which there may not be) the product returning no product results.

The rs am using is

<?php
$Categories = new WA_MySQLi_RS("Categories",$DBConnection,0);
$Categories->setQuery("SELECT products.*, downloadproductjoin.*, download.* FROM products LEFT OUTER JOIN downloadproductjoin ON products.ProductID = downloadproductjoin.JoinProductID INNER JOIN download ON downloadproductjoin.JoinDownloadID = download.DownloadID WHERE products.ProdPermalink = ? AND products.ProductLive = 1 AND download.Live = 1");
$Categories->bindParam("s", "".$_GET["perm"]  ."", "-1"); //WAQB_Param1
$Categories->execute();
?>

and theres more info in the PM

You are using an INNER JOIN instead of LEFT OUTER JOIN, the LEFT OUTER JOIN will always return the row even if there are no downloads.

thats great thanks.

now the AND download.Live = 1 will only allow the product to show if the download is set to Live otherwise the product would show as no results.

how would I modify the rs to allow the product detail to show even if the download(s) were not live?

Put the check in the join instead of the where clause like:

SELECT products.*, downloadproductjoin.*, download.* FROM products LEFT OUTER JOIN downloadproductjoin ON products.ProductID = downloadproductjoin.JoinProductID LEFT OUTER JOIN download ON downloadproductjoin.JoinDownloadID = download.DownloadID AND download.Live = 1 WHERE products.ProdPermalink = ? AND products.ProductLive = 1

brilliant thank you

last question on this, how would I now write an if statement to show content if the downloads side of the rs is empty ?

if (!$Categories->getColumnVal("DownloadID")) {